[
https://issues.apache.org/jira/browse/METAMODEL-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15051496#comment-15051496
]
ASF GitHub Bot commented on METAMODEL-6:
----------------------------------------
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/77#issuecomment-163724465
Maybe someone would like to give their feedback on this change? Since it
changes the return type of ```executeUpdate``` it will mean that all using code
has to be recompiled. I guess we need that sooner than later. But just want to
ensure that you agree on the change?
> Get back update status after invoking executeUpdate(...)
> --------------------------------------------------------
>
> Key: METAMODEL-6
> URL: https://issues.apache.org/jira/browse/METAMODEL-6
> Project: Apache MetaModel
> Issue Type: Wish
> Reporter: Kasper Sørensen
> Assignee: Kasper Sørensen
> Priority: Minor
>
> In the current API design of MetaModel, the DataContext.executeUpdate(...)
> method is a void method. This was initially chosen because not all
> implementations have the capability to report anything about a particular
> update. But some do, for instance the no. of inserted, updated or deleted
> records from a JDBC call. It would be nice to expose this information when
> available.
> My suggestion for this would be to let the DataContext.executeUpdate(...)
> method return an object with this information. All methods on the new object
> type would be optionally returning null, if no information is available. But
> when available, we can at least expose it this way.
> The change wouldn't have a major impact, since any project using MetaModel
> would already need to recompile because of the namespace change to
> org.apache.metamodel. And the change would be compile-time compatible with
> having a void return type.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
