[
https://issues.apache.org/jira/browse/METAMODEL-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056718#comment-15056718
]
ASF GitHub Bot commented on METAMODEL-6:
----------------------------------------
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/81
METAMODEL-6: Execute update summary
Hereby a new PR for METAMODEL-6. The previous one (#77) would target the
master branch. This one targets the new 5.x branch and requires the Java 8 PR
to be merged first (see #80).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel
METAMODEL-6/execute-update-return-value
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/81.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #81
----
commit a15ca724b5c4556ebb65700b4d50db878b6b159c
Author: Kasper Sørensen <[email protected]>
Date: 2015-12-09T12:14:07Z
First attempts at making the API change for METAMODEL-6
commit 774cb596e70ab939b262218f7d908cd5164161ba
Author: Kasper Sørensen <[email protected]>
Date: 2015-12-11T10:28:33Z
Added javadoc for METAMODEL-6
commit 1bc6b6b3aae6d3318b2344314685d03ef0b9749b
Author: Kasper Sørensen <[email protected]>
Date: 2015-12-14T20:48:44Z
METAMODEL-222: Removed Java 7 compatibility and build options
commit d6ab0bed337fcfc3dd673ed0f9ef4d6e447217af
Author: Kasper Sørensen <[email protected]>
Date: 2015-12-14T20:54:11Z
Merge branch '5.x' into METAMODEL-6/execute-update-return-value
commit 58f8c2a297911cc591469d24ca14140185a04e13
Author: Kasper Sørensen <[email protected]>
Date: 2015-12-14T20:54:36Z
Merge branch 'METAMODEL-222/java8-only' into
METAMODEL-6/execute-update-return-value
commit 5f478328f697437d6883b8adc95a12122bdf3cc4
Author: Kasper Sørensen <[email protected]>
Date: 2015-12-14T20:58:34Z
METAMODEL-6: Changed API to use the Java 8 Optional interface
----
> Get back update status after invoking executeUpdate(...)
> --------------------------------------------------------
>
> Key: METAMODEL-6
> URL: https://issues.apache.org/jira/browse/METAMODEL-6
> Project: Apache MetaModel
> Issue Type: Wish
> Reporter: Kasper Sørensen
> Assignee: Kasper Sørensen
> Priority: Minor
> Fix For: 5.0.0
>
>
> In the current API design of MetaModel, the DataContext.executeUpdate(...)
> method is a void method. This was initially chosen because not all
> implementations have the capability to report anything about a particular
> update. But some do, for instance the no. of inserted, updated or deleted
> records from a JDBC call. It would be nice to expose this information when
> available.
> My suggestion for this would be to let the DataContext.executeUpdate(...)
> method return an object with this information. All methods on the new object
> type would be optionally returning null, if no information is available. But
> when available, we can at least expose it this way.
> The change wouldn't have a major impact, since any project using MetaModel
> would already need to recompile because of the namespace change to
> org.apache.metamodel. And the change would be compile-time compatible with
> having a void return type.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
