[ 
https://issues.apache.org/jira/browse/METAMODEL-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063787#comment-15063787
 ] 

ASF GitHub Bot commented on METAMODEL-224:
------------------------------------------

Github user kaspersorensen commented on the pull request:

    https://github.com/apache/metamodel/pull/82#issuecomment-165740056
  
    That sounds a bit strange because only very specific query types do that. 
For instance "primary key lookup" queries and "select count(*)" queries. But 
OK, maybe your query is a primary key lookup with a scalar function on it? 
Could be.
    
    And I guess that really reveals the problem... That in 
```executePrimaryKeyLookupQuery(...)``` we are _passing in_ the select item. 
That used to be OK because select items wasn't that difficult. But now it 
select item is more complicated. So maybe we should rather change the contract 
so that ```executePrimaryKeyLookupQuery(...)```, 
```materializeMainSchemaTable``` and any similar methods do NOT get a list of 
select items, but instead get a list of columns. And then their results will be 
generically postprocessed to add the scalar function layer on top.


> Support CONCAT function
> -----------------------
>
>                 Key: METAMODEL-224
>                 URL: https://issues.apache.org/jira/browse/METAMODEL-224
>             Project: Apache MetaModel
>          Issue Type: New Feature
>            Reporter: Alberto
>            Priority: Minor
>
> As we now support scalar functions it would be great to add support for a 
> CONCAT function that allow us to concatenate and append strings to the query 
> results.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to