[jira] [Commented] (METAMODEL-183) For Mongo DB model, use new APIs instead of old ones.

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/METAMODEL-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089111#comment-15089111
 ] 

ASF GitHub Bot commented on METAMODEL-183:
------------------------------------------

Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/86#discussion_r49182098
  
    --- Diff: mongodb/common/pom.xml ---
    @@ -0,0 +1,66 @@
    +<?xml version="1.0" encoding="UTF-8" ?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
    +   <parent>
    +           <artifactId>MetaModel-mongodb</artifactId>
    +           <groupId>org.apache.metamodel</groupId>
    +           <version>4.5.1-SNAPSHOT</version>
    +   </parent>
    +   <modelVersion>4.0.0</modelVersion>
    +   <artifactId>MetaModel-mongodb-common</artifactId>
    +   <name>MetaModel module for MongoDB commons</name>
    +   
    +   <dependencies>
    +           <dependency>
    +                   <groupId>org.apache.metamodel</groupId>
    +                   <artifactId>MetaModel-core</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.mongodb</groupId>
    +                   <artifactId>mongo-java-driver</artifactId>
    +                   <version>3.1.0</version>
    --- End diff --
    
    I would put this dependency as scope=provided so we don't make the 
common-module too specific to a particular version (after all stuff in common 
should work for both 2.x and 3.x)


> For Mongo DB model, use new APIs instead of old ones.
> -----------------------------------------------------
>
>                 Key: METAMODEL-183
>                 URL: https://issues.apache.org/jira/browse/METAMODEL-183
>             Project: Apache MetaModel
>          Issue Type: Improvement
>            Reporter: Hosur Narahari
>            Priority: Minor
>
> I observed that we are using old APIs of MongoDB in our metamodel project, 
> like Mongo instead of MongoClient, DB instead of MongoDatabase and many more. 
> It would be better if we replace this with new API as support for Mongo 
> driver would be for the new one.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)