[
https://issues.apache.org/jira/browse/METAMODEL-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089309#comment-15089309
]
ASF GitHub Bot commented on METAMODEL-228:
------------------------------------------
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/87
METAMODEL-228: Fixed
Fixes METAMODEL-228 - that converting from Number.class to ColumnType
should resolve to ColumnType.NUMBER. And similarly from String.class to STRING
instead of VARCHAR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel
METAMODEL-228/convert-column-type
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/87.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #87
----
commit 510a64e01a76061798d772e10b1fd4bf9cbe1c34
Author: Kasper Sørensen <[email protected]>
Date: 2016-01-08T14:58:49Z
METAMODEL-228: Fixed
----
> ColumnTypeImpl.convertColumnType(...) does not support Number.class
> -------------------------------------------------------------------
>
> Key: METAMODEL-228
> URL: https://issues.apache.org/jira/browse/METAMODEL-228
> Project: Apache MetaModel
> Issue Type: Bug
> Affects Versions: 4.5.0
> Reporter: Kasper Sørensen
> Labels: starter
>
> Calling ColumnTypeImpl.convertColumnType(...) does not yield
> ColumnType.NUMBER as I would expect it to.
> Similarly I would also expect it to return ColumnType.STRING instead of
> VARCHAR when invoked with String.class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
