[
https://issues.apache.org/jira/browse/METAMODEL-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093983#comment-15093983
]
ASF GitHub Bot commented on METAMODEL-224:
------------------------------------------
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/85#discussion_r49462089
--- Diff: core/src/main/java/org/apache/metamodel/query/SelectItem.java ---
@@ -461,8 +472,11 @@ public StringBuilder toStringNoAlias() {
public StringBuilder toStringNoAlias(boolean
includeSchemaInColumnPath) {
final StringBuilder sb = new StringBuilder();
if (_column != null) {
- sb.append(getToStringColumnPrefix(includeSchemaInColumnPath));
- sb.append(_column.getQuotedName());
+ if (_function==null ||
+ (_function!=null &&
!_function.getFunctionName().equals(FunctionType.CONCAT.getFunctionName()))) {
--- End diff --
Unclear to me why this is needed. I would prefer this to be really agnostic
of function type. Any function should be able to have a mix of parameter types
(if that is somehow the reason for this if - I'm unsure).
> Support CONCAT function
> -----------------------
>
> Key: METAMODEL-224
> URL: https://issues.apache.org/jira/browse/METAMODEL-224
> Project: Apache MetaModel
> Issue Type: New Feature
> Reporter: Alberto
> Priority: Minor
>
> As we now support scalar functions it would be great to add support for a
> CONCAT function that allow us to concatenate and append strings to the query
> results.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
