[ 
https://issues.apache.org/jira/browse/METAMODEL-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119839#comment-15119839
 ] 

Kasper Sørensen commented on METAMODEL-230:
-------------------------------------------

That might be a way, but it would still be more convenient (and relatively easy 
and in line with the rest of the implementation) to provide both a client and a 
set of credentials.

The important aspect about this is also that the HttpClient is closeable. And 
DataContext is not. So if you want to control when it is closed then you will 
want to provide it yourself via the constructor. This is IMO a valid scenario 
both for cases where you want to prematurely close the client (and somehow 
invalidate the DataContext) or in cases where you are just cleaning up after 
the DataContext.

Yes, it can be done with an AuthenticationProvider, but that is arguably more 
involved while the DataContext already implements request-level authentication.

> Neo4jDataContext constructors matrix is not complete
> ----------------------------------------------------
>
>                 Key: METAMODEL-230
>                 URL: https://issues.apache.org/jira/browse/METAMODEL-230
>             Project: Apache MetaModel
>          Issue Type: Bug
>            Reporter: Claudia Pesu
>            Priority: Minor
>
> Some Neo4jDataContext constructors that take a CloseableHttpClient as 
> parameter, doesn't give the possibility to insert the login credentials. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to