Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/105#issuecomment-221327239
+0
Code is acceptable from me, but I think it would be better to separate
"parser" from "reader" here. A reader is a stateful thing IMO - it has a
pointer/cursor to some data that it is reading through and it is also
closeable. The parsing part however can have a different scope or maybe even be
completely stateless. So I would prefer if we make two different classes for it
(the reader will probably use the parser, but not the other way around).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
