Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/122#discussion_r73817859
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthReader.java
---
@@ -43,6 +47,7 @@
private final boolean _constantWidth;
private volatile int _rowNumber;
protected final BufferedInputStream _stream;
+ protected Reader _reader;
--- End diff --
I would suggest to keep having final fields only, and since `_stream` and
`_charset` are no longer really used, I'd suggest to remove those and instead
make the `initReader` return the created Reader with the needed arguments, like
this:
```
_reader = initReader(stream, charsetName);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
