Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/124#discussion_r75277252
  
    --- Diff: 
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/SQLServerQueryRewriter.java
 ---
    @@ -116,6 +116,14 @@ public String rewriteFilterItem(FilterItem item) {
                     final String dateTimeValue = "CAST('" + 
format.format(date) + "' AS DATETIME)";
     
                     sb.append(dateTimeValue);
    +
    +                //Remove TIMESTAMP token as SQL Server doesn't support it
    +                int timestampIndex = sb.lastIndexOf("TIMESTAMP");
    --- End diff --
    
    Hmmm, weird. I guess it could happen in other cases, then. My testing also 
seemed to show that the SqlServerQueryRewriter more or less deferred to the 
DefaultQueryRewriter directly after looking at the types etc..
    
    @olafgarten I'm afraid you'll have to create a unit test showing the 
problem before we can act on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to