Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/137#discussion_r91810234
--- Diff:
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/AbstractQueryRewriter.java
---
@@ -460,4 +460,25 @@ public Object getResultSetValue(ResultSet resultSet,
int columnIndex, Column col
}
return resultSet.getObject(columnIndex);
}
+
+ protected boolean isSupportedVersion(String databaseProductName, int
databaseVersion) {
+
+
if(databaseProductName.equals(_dataContext.getDatabaseProductName())
+ && databaseVersion <=
databaseVersionToInt(_dataContext.getDatabaseVersion())) {
+ return true;
+ }
+ return false;
+ }
+
+ private int databaseVersionToInt(String version) {
--- End diff --
I'd call this method something like `getDatabaseMajorVersion()` just
because it will return the _major_ version element only, not something that
represents the 'real' version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
