Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/150#discussion_r128900981
--- Diff: jdbc/src/test/java/org/apache/metamodel/jdbc/HsqldbTest.java ---
@@ -417,4 +418,98 @@ public void testInterpretationOfNull() throws
Exception {
Connection conn =
DriverManager.getConnection("jdbc:hsqldb:mem:interpretation_of_null", USERNAME,
PASSWORD);
JdbcTestTemplates.interpretationOfNulls(conn);
}
+
+ public void testCapitalization() throws Exception{
+ try(Connection connection =
DriverManager.getConnection("jdbc:hsqldb:mem:different_types_insert",
USERNAME,PASSWORD);){
--- End diff --
Coding conventions/formatting rule: There should be a space between "try"
and "(".
(same rule is relevant other places in the diff, this is just an example)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
