GitHub user tomatophantastico opened a pull request:
https://github.com/apache/metamodel/pull/156
Checkstyle integration
Integrates checkstyle into the maven test phase: so when ever mvn test is
called, checkstyle is run and fails on violations.
This should be subject to discussion, especially with more controversial
code styling rules (tabs/spaces anyone?)
I only activated three rules:
unused imports -> self-explanatory
import order -> enforce eclipse ordering, therefore smaller commits, when
using different IDEs
licence -> rat checks if present, this one however enforces 1:1 identity
with the context of the text file. I found and corrected some deviations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tomatophantastico/metamodel feature/checkstyle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #156
----
commit cebf2e1833f58f729a47ef0894a9c876a8b44879
Author: JoÌrg Unbehauen <[email protected]>
Date: 2017-08-02T12:40:27Z
initial check style checkin
commit b371c0a6a5097c8c047860a4ca29cd09a2bfa421
Author: JoÌrg Unbehauen <[email protected]>
Date: 2017-08-02T13:03:40Z
include javadoc in analysis
commit 28b58e078c443a89222049d43bdc85c8d209961d
Author: JoÌrg Unbehauen <[email protected]>
Date: 2017-08-02T15:43:18Z
check style for header and eclipse import order
commit 4abb5bc7266483b0e3977a4730ed31f18312259c
Author: JoÌrg Unbehauen <[email protected]>
Date: 2017-08-02T15:44:08Z
small fixes to import, import order or license header to keep up with the
check style rules
commit 3038fcdc47228adf05272c86fc23b9426d338928
Author: JoÌrg Unbehauen <[email protected]>
Date: 2017-08-07T10:57:25Z
Merge branch 'master' into feature/checkstyle
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
