Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/160#discussion_r136374486
  
    --- Diff: 
core/src/main/java/org/apache/metamodel/schema/MutableRelationship.java ---
    @@ -134,4 +139,17 @@ private MutableRelationship(List<Column> 
primaryColumns, List<Column> foreignCol
                return _foreignColumns;
        }
     
    +    private void readObject(ObjectInputStream stream) throws IOException, 
ClassNotFoundException {
    +        final GetField getFields = stream.readFields();
    +        Object primaryColumns = getFields.get("_primaryColumns", null);
    +        Object foreignColumns = getFields.get("_foreignColumns", null);
    +        if (primaryColumns instanceof Column[] && foreignColumns 
instanceof Column[]) {
    --- End diff --
    
    In our history it has only been either-or. Of course someone (slightly 
crazy) could of course change one of them back to an array and then we'd have 
an interesting new issue to work on :-) But I argue that the only scenario 
worth worrying about now is that it's the singular "old class format" where 
they both where arrays.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to