Normally if I'm upgrading a project that I depend on from e.g. 4.x to 5.x, then I would expect differences and do some testing to make sure everything in the upgrade fits my bill. But you do have a point of course.
I say we extent the vote for another 24 hours to see if any other PMC members have anything to add about this concern. I am myself fully OK with the impact of METAMODEL-1165, and prefer not to hold up the release. 2017-11-06 14:11 GMT-08:00 <unbeha...@informatik.uni-leipzig.de>: > Hi Kasper, > > this feature should be released in 5.0.0 (i am @tomatophantastico on > github), just the schedule is quite tight. > > When i build my project against master (thanks for the great work btw.), i > had to do some adjustments (i.e. filter tables & dealing with other table > types) that i did not considered before. > As this change is not reflected in an API change and affects only a subset > of datacontexts, this might slip unnoticed and cause confusion afterwards. > > > As i have no knowledge about the other projects using metamodel, this can > be either an issue, or not. > > > Best, Jörg > > > > > Quoting Kasper Sørensen <i.am.kasper.soren...@gmail.com>: > > Hi Jörg, >> >> Thank you for the feedback. But the way I see it there are two >> counter-arguments to what you're saying ... >> >> (1) Being a major release (5.0.0), changing behavior is warranted and >> clearly signalled, and the time is right to do so now, not in any other >> kind of release. >> (2) There is a system property available (metamodel.alias.default.table) >> which allows one to turn off the feature. >> >> Best regards, >> Kasper >> >> 2017-11-06 10:00 GMT-08:00 Jörg Unbehauen < >> unbeha...@informatik.uni-leipzig.de>: >> >> -1 >>> >>> Sorry for being late, but while i really like METAMODEL-1165 and >>> appreciate having it shipped with MM 5.0, it changes the behavior without >>> an API change, so unsuspecting users might run into trouble. >>> >>> I suggest to either create an other RC, or turn it off by default. >>> >>> >>> >>> Best, Jörg >>> >>> >>> Am 06.11.17 um 07:59 schrieb Alberto Rodriguez: >>> >>> +1 >>> >>>> >>>> 2017-11-06 7:53 GMT+01:00 David Krause <david.krause...@gmail.com>: >>>> >>>> +1 >>>> >>>>> >>>>> Freundliche Grüße >>>>> David >>>>> >>>>> >>>>> >>> > > >
