Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/171#discussion_r155709789
--- Diff:
core/src/main/java/org/apache/metamodel/data/SimpleDataSetHeader.java ---
@@ -104,12 +104,6 @@ public int indexOf(SelectItem item) {
}
i++;
}
-
- final boolean scalarFunctionQueried = item.getScalarFunction() !=
null;
- if (scalarFunctionQueried) {
- final SelectItem itemWithoutFunction =
item.replaceFunction(null);
- return indexOf(itemWithoutFunction);
--- End diff --
Similarly, this special if-block for scalar functions was kind of a bad
code smell that's now gone :-)
---
