Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/177#discussion_r163751523
  
    --- Diff: elasticsearch/rest/pom.xml ---
    @@ -52,40 +51,117 @@ under the License.
                        <artifactId>commons-io</artifactId>
                </dependency>
     
    -           <!-- Jest -->
    -           <dependency>
    -                   <groupId>io.searchbox</groupId>
    -                   <artifactId>jest</artifactId>
    -                   <version>${jest.version}</version>
    -                   <exclusions>
    -                           <exclusion>
    -                                   <groupId>commons-logging</groupId>
    -                                   <artifactId>commons-logging</artifactId>
    -                           </exclusion>
    -                   </exclusions>
    -           </dependency>
    -
                <dependency>
                        <groupId>org.slf4j</groupId>
                        <artifactId>jcl-over-slf4j</artifactId>
                </dependency>
                <!-- elasticsearch -->
                <dependency>
    -                   <groupId>org.elasticsearch</groupId>
    -                   <artifactId>elasticsearch</artifactId>
    +                   <groupId>org.elasticsearch.client</groupId>
    +                   
<artifactId>elasticsearch-rest-high-level-client</artifactId>
                        <version>${elasticsearch.version}</version>
    +                   <exclusions>
    +                           <exclusion>
    +                                   <groupId>commons-logging</groupId>
    +                                   <artifactId>commons-logging</artifactId>
    +                           </exclusion>
    +                   </exclusions>
                </dependency>
     
                <!-- test -->
    -           <dependency>
    -                   <groupId>org.slf4j</groupId>
    -                   <artifactId>slf4j-log4j12</artifactId>
    +           <dependency><!-- required by elasticsearch -->
    +                   <groupId>org.apache.logging.log4j</groupId>
    +                   <artifactId>log4j-core</artifactId>
    +                   <version>2.9.1</version>
                        <scope>test</scope>
                </dependency>
                <dependency>
                        <groupId>junit</groupId>
                        <artifactId>junit</artifactId>
                        <scope>test</scope>
                </dependency>
    +
    +           <dependency>
    +                   <groupId>org.hamcrest</groupId>
    +               <artifactId>hamcrest-all</artifactId>
    +               <version>1.3</version>
    +               <scope>test</scope>
    +           </dependency>
        </dependencies>
    +   <profiles>
    +           <profile>
    +                   <id>integration-test</id>
    +                   <build>
    +                           <plugins>
    +                                   <plugin>
    +                                           
<artifactId>maven-failsafe-plugin</artifactId>
    +                                           <version>2.19.1</version>
    +                                           <executions>
    +                                                   <execution>
    +                                                           <goals>
    +                                                                   
<goal>integration-test</goal>
    +                                                                   
<goal>verify</goal>
    +                                                           </goals>
    +                                                   </execution>
    +                                           </executions>
    +                                   </plugin>
    +
    +                                   <plugin>
    +                                           <groupId>io.fabric8</groupId>
    +                                           
<artifactId>docker-maven-plugin</artifactId>
    +                                           <version>0.15.16</version>
    --- End diff --
    
    It's a fairly old version of this plugin that you're using here. Maybe we 
should (1) use the latest just because Docker things like this seems to move 
fast and (2) add it's version to <pluginManagement> in the root pom.


---

Reply via email to