Github user arjansh commented on a diff in the pull request: https://github.com/apache/metamodel/pull/179#discussion_r189905854 --- Diff: neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java --- @@ -0,0 +1,117 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.metamodel.neo4j.utils; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Iterator; +import java.util.List; + +import org.apache.metamodel.schema.ColumnType; +import org.json.JSONException; +import org.json.JSONObject; + +public class ColumnTypeResolver { --- End diff -- If I look at the manner in which this class is instantiated and in the manner in which the getColumnTypes method is invoked, I would either refactor it into a helper class with only static methods and a private no args constructor, or leave it like it is, but then add a constructor to it which takes a `JSONObject` as an argument, so it doesn't need to be passed through in all methods on the class.
---