Github user jhorcicka commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/179#discussion_r191188566
  
    --- Diff: 
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
    @@ -0,0 +1,126 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.metamodel.neo4j.utils;
    +
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.Iterator;
    +import java.util.List;
    +
    +import org.apache.metamodel.schema.ColumnType;
    +import org.json.JSONArray;
    +import org.json.JSONException;
    +import org.json.JSONObject;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +public class ColumnTypeResolver {
    +    private static final Logger logger = 
LoggerFactory.getLogger(ColumnTypeResolver.class);
    +    private final JSONObject _jsonObject;
    +    private final List<String> _columnNames = new ArrayList<>();
    +    private final List<ColumnType> _columnTypes = new ArrayList<>();
    --- End diff --
    
    Sure. What is the benefit of that? 


---

Reply via email to