[GitHub] metamodel pull request #205: close ResultSet after get result

[q977734161]

Github user q977734161 commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/205#discussion_r245537238
  
    --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java 
---
    @@ -580,6 +587,13 @@ public void close(Connection connection, ResultSet rs, 
Statement st) {
             } catch (SQLException e) {
                 logger.error("Error retrieving catalog metadata", e);
             } finally {
    +            if(rs != null){
    +                try {
    +                    rs.close();
    --- End diff --
    
    ok.I will improve the code.Thanks for review.


---