kaspersorensen commented on a change in pull request #221: Access CSVParser in
a synchronized manner
URL: https://github.com/apache/metamodel/pull/221#discussion_r293772108
##########
File path: csv/src/main/java/org/apache/metamodel/csv/SingleLineCsvDataSet.java
##########
@@ -44,20 +44,56 @@
private final ICSVParser _csvParser;
private final int _columnsInTable;
private final boolean _failOnInconsistentRowLength;
-
+ private final CsvConfiguration _csvConfiguration;
+
private volatile int _rowNumber;
private volatile Integer _rowsRemaining;
private volatile Row _row;
+ /**
+ * @param reader
+ * @param csvParser
+ * @param columns
+ * @param maxRows
+ * @param columnsInTable
+ * @param failOnInconsistentRowLength
+ *
+ * @deprecated When instantiating a {@link SingleLineCsvDataSet} using
this constructor the {@link ICSVParser} can
+ * be reused in different threads in a parallel manner which
is not promised to work by the
+ * {@link ICSVParser}. Use
+ * {@link #SingleLineCsvDataSet(BufferedReader,
CsvConfiguration, List, Integer, int, boolean)} instead.
+ */
+ @Deprecated
Review comment:
This class is not public however, so we don't even need to worry about
deprecation etc. Just whack the old constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
