LosD commented on a change in pull request #222: METAMODEL-1151: Fixed by adding DataContextFactory for SugarCRM. URL: https://github.com/apache/metamodel/pull/222#discussion_r305743735
########## File path: sugarcrm/src/main/java/org/apache/metamodel/sugarcrm/SugarCrmDataContextFactory.java ########## @@ -0,0 +1,48 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.metamodel.sugarcrm; + +import org.apache.metamodel.ConnectionException; +import org.apache.metamodel.DataContext; +import org.apache.metamodel.factory.AbstractDataContextFactory; +import org.apache.metamodel.factory.DataContextFactory; +import org.apache.metamodel.factory.DataContextProperties; +import org.apache.metamodel.factory.ResourceFactoryRegistry; +import org.apache.metamodel.factory.UnsupportedDataContextPropertiesException; + +/** + * {@link DataContextFactory} for SugarCRM. + */ +public class SugarCrmDataContextFactory extends AbstractDataContextFactory { + + @Override + protected String getType() { + return "sugarcrm"; + } + + @Override + public DataContext create(DataContextProperties properties, ResourceFactoryRegistry resourceFactoryRegistry) Review comment: Can't remember if we have "rules" here, but why not `final`? Arguments are just as susceptible to being manipulated as variables, and can be just as surprising (if not more). (of course, in as simple a function as this, it doesn't really matter for any of them) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
