kaspersorensen commented on a change in pull request #227: MM-1219 Returning
schemas SQL Server
URL: https://github.com/apache/metamodel/pull/227#discussion_r320432527
##########
File path: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java
##########
@@ -778,18 +780,33 @@ private String findDefaultSchema(final String
defaultName, final List<String> sc
* @throws SQLException
*/
private Set<String> getSchemaSQLServerNames(DatabaseMetaData metaData)
throws SQLException {
- // Distinct schema names. metaData.getTables() is a denormalized
- // resultset
- Set<String> schemas = new HashSet<>();
- ResultSet rs = null;
+ // Distinct schema names. metaData.getTables() is a denormalized
resultset
+ final Set<String> schemas = new HashSet<>();
+ ResultSet resultSet = null;
+
+ // Find DBO schema if present
try {
Review comment:
Well yes and no. There is a difference... the `safeClose` method will log
but ignore any exceptions. It was built from a mentality of "close this
resource, but if that fails I don't know that we can do anything about it".
I'm OK with changing it though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
