arjansh commented on a change in pull request #230: dev/add datatypes to excel
columns
URL: https://github.com/apache/metamodel/pull/230#discussion_r330048478
##########
File path:
excel/src/main/java/org/apache/metamodel/excel/ExcelConfiguration.java
##########
@@ -102,17 +114,29 @@ public boolean isSkipEmptyColumns() {
return skipEmptyColumns;
}
+ /**
+ * Defines if columns in the excel spreadsheet should be validated on
datatypes while
+ * reading the spreadsheet.
+ *
+ * @return a boolean indicating whether or not to validate column types.
+ */
+ public boolean isValidateColumnTypes() {
+ return validateColumnTypes;
+ }
+
@Override
protected void decorateIdentity(List<Object> identifiers) {
identifiers.add(columnNameLineNumber);
identifiers.add(skipEmptyLines);
identifiers.add(skipEmptyColumns);
+ identifiers.add(validateColumnTypes);
Review comment:
Indentation is off.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services