GerardDellemann commented on a change in pull request #234: MM-82 Detect Column
Types
URL: https://github.com/apache/metamodel/pull/234#discussion_r354187835
##########
File path:
excel/src/main/java/org/apache/metamodel/excel/ExcelConfiguration.java
##########
@@ -102,17 +115,39 @@ public boolean isSkipEmptyColumns() {
return skipEmptyColumns;
}
+ /**
+ * Defines if columns in the excel spreadsheet should be validated on
datatypes while
Review comment:
I've changed this JavaDoc. Do note that in order to stay backwards
compatible it's either String or VarChar depending on the Column Name Line
configuration. I try to explain the differences in the JavaDoc.
I think we should only return String soon. The current situation is hard to
understand and very confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
