arjansh commented on a change in pull request #234: MM-82 Detect Column Types
URL: https://github.com/apache/metamodel/pull/234#discussion_r355949682
##########
File path: excel/src/main/java/org/apache/metamodel/excel/ExcelUtils.java
##########
@@ -232,53 +249,119 @@ public static String getCellValue(Workbook wb, Cell
cell) {
throw new IllegalStateException("Unknown cell type: " +
cell.getCellType());
}
- logger.debug("cell {} resolved to value: {}", cellCoordinate, result);
+ logger.debug("cell ({},{}) resolved to value: {}", cell.getRowIndex(),
cell.getColumnIndex(), result);
return result;
}
- private static String getFormulaCellValue(Workbook wb, Cell cell) {
+ private static Object getErrorResult(final Cell cell) {
Review comment:
This method always returns a `String` (unless it throws an Exception of
course), so why not change the return signature to `String`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
