jhorcicka commented on a change in pull request #243:
URL: https://github.com/apache/metamodel/pull/243#discussion_r450215387



##########
File path: 
elasticsearch/common/src/main/java/org/apache/metamodel/elasticsearch/common/ElasticSearchUtils.java
##########
@@ -290,6 +290,23 @@ public static Row createRow(final Map<String, Object> 
sourceMap, final String do
                         } else {
                             values[i] = valueToDate;
                         }
+                    } else if (column.getType() == ColumnType.MAP && value == 
null) {
+                        // Because of a bug in Elasticsearch, when field names 
contain dots, it's possible that the
+                        // mapping of the index described a column to be of 
the type "MAP", while it's based on a number
+                        // of fields contains dots in their name. In this case 
we may have to work around that

Review comment:
       "contains dots..." => "containing dots..."




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to