arjansh commented on a change in pull request #241:
URL: https://github.com/apache/metamodel/pull/241#discussion_r450638837
##########
File path: core/src/main/java/org/apache/metamodel/schema/ImmutableColumn.java
##########
@@ -71,12 +72,13 @@
* whether the column is a primary key or not
*/
public ImmutableColumn(String name, ColumnType type, Table table, int
columnNumber, Integer columnSize,
- String nativeType, Boolean nullable, String remarks, boolean
indexed, String quote, boolean primaryKey) {
+ Integer decimalDigits, String nativeType, Boolean
nullable, String remarks, boolean indexed, String quote, boolean primaryKey) {
Review comment:
This looks good now.
##########
File path: core/src/main/java/org/apache/metamodel/schema/MutableColumn.java
##########
@@ -70,9 +71,10 @@ public MutableColumn(String name, ColumnType type, Table
table, int columnNumber
}
public MutableColumn(String name, ColumnType type, Table table, int
columnNumber, Integer columnSize,
- String nativeType, Boolean nullable, String remarks, boolean
indexed, String quote) {
+ Integer decimalDigits, String nativeType, Boolean
nullable, String remarks, boolean indexed, String quote) {
Review comment:
This looks good now.
##########
File path: core/src/main/java/org/apache/metamodel/schema/ImmutableColumn.java
##########
@@ -38,12 +38,55 @@
private final Boolean nullable;
private final String remarks;
private final Integer columnSize;
+ private final Integer decimalDigits;
private final String nativeType;
private final boolean indexed;
private final boolean primaryKey;
private final String name;
private final String quote;
+ /**
+ * Constructs a new {@link ImmutableColumn}.
+ *
+ * @param name
+ * the name of the column
+ * @param type
+ * the type of the column
+ * @param table
+ * the table which the constructed column will pertain to
+ * @param columnNumber
+ * the column number of the column
+ * @param columnSize
+ * the size of the column
+ * @param nativeType
+ * the native type of the column
+ * @param nullable
+ * whether the column's values are nullable
+ * @param remarks
+ * the remarks of the column
+ * @param indexed
+ * whether the column is indexed or not
+ * @param quote
+ * the quote character(s) of the column
+ * @param primaryKey
+ * whether the column is a primary key or not
+ */
+ public ImmutableColumn(String name, ColumnType type, Table table, int
columnNumber, Integer columnSize,
+ String nativeType, Boolean nullable, String
remarks, boolean indexed, String quote, boolean primaryKey) {
+ this.name = name;
Review comment:
This looks good now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
