arjansh opened a new pull request #247:
URL: https://github.com/apache/metamodel/pull/247


   Fixes https://issues.apache.org/jira/browse/METAMODEL-1232.
   
   - I refactored the `ExcelDataContextTest` from using JUnit 3 to JUnit 4, so 
it can use the ` TemporaryFolder` rule for copying files when using them it 
tests. It seems this works better than when copying them to the target folder.
   - I refactored the logic used by `ElasticSearchUtils#createRow(...)`  for 
creating a row based on a MAP column type. It uses `computeIfAbsent` to put a 
`HashMap`  in a `Map`, but then within the method that created that `HashMap`, 
it would already add the created `HashMap` to the `Map`, which is something 
that should be handled by the `computeIfAbsent` itself, which apparently can 
lead to `ConcurrentModificationExpection`s being thrown.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to