arjansh commented on a change in pull request #245:
URL: https://github.com/apache/metamodel/pull/245#discussion_r557250383
##########
File path:
jdbc/src/test/java/org/apache/metamodel/jdbc/integrationtests/PostgresqlTest.java
##########
@@ -92,13 +99,14 @@ public void testCompositePrimaryKeyCreation() throws
Exception {
JdbcTestTemplates.compositeKeyCreation(getDataContext(),
"metamodel_test_composite_keys");
}
+ @Test
public void testInterpretationOfNull() throws Exception {
if (!isConfigured()) {
return;
}
JdbcTestTemplates.interpretationOfNulls(getConnection());
}
-
+
Review comment:
Can you remove these trailing white-spaces?
##########
File path:
jdbc/src/test/java/org/apache/metamodel/jdbc/integrationtests/DB2Test.java
##########
@@ -26,6 +26,8 @@
import org.apache.metamodel.query.Query;
import org.apache.metamodel.schema.Schema;
import org.apache.metamodel.schema.Table;
+import org.junit.Test;
+import static org.junit.Assert.*;
Review comment:
Static imports are usually put at the top of the import list. (this
comment applies to all java files where you added static imports). If your
using an IDE, check if it contains an "Organize Imports" option. If so, please
apply it to the files you changed. It should move the static imports to the top
(and maybe reorganize some other imports too).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
