The log4j.xml is in src/test/resources, so it doesn't affect any production code. But it makes stuff more visible for the unittest logs. It was only added to verify that the debug logging statement that was in the fix looked alright.
2013/7/24 Henry Saputra <[email protected]> > +1 > > not sure about log4j.xml change. That's not part of the fix, is it? > > - Henry > > > > On Tue, Jul 23, 2013 at 2:31 AM, Kasper Sørensen < > [email protected]> wrote: > > > Yep, good idea with the gist. Here it is: > > https://gist.github.com/kaspersorensen/6061171 > > > > > > > > 2013/7/23 Henry Saputra <[email protected]> > > > > > Ah yes maybe you cant attach file to maling list :(ue > > > > > > I have created INFRA-6581 to track request for review board group for > > > metamodel. > > > > > > Could you upload the patch to online place like > > https://gist.github.com/for > > > a while. > > > > > > Sorry about delay in infra support. > > > > > > - Henry > > > > > > > > > On Mon, Jul 22, 2013 at 11:38 PM, Kasper Sørensen < > > > [email protected]> wrote: > > > > > > > I did attach a regular file, but maybe that's not possible via this > > > mailing > > > > list? Do you want me to just copy the patch contents into the email > > > > content? > > > > > > > > > > > > 2013/7/22 Henry Saputra <[email protected]> > > > > > > > > > HI Kasper, is it just me or there was no attachment to the email > > > response > > > > > you sent? > > > > > > > > > > > > > > > On Mon, Jul 22, 2013 at 3:10 AM, Kasper Sørensen < > > > > > [email protected]> wrote: > > > > > > > > > > > Here's a patch to fix the issue. > > > > > > > > > > > > > > > > > > 2013/7/22 Kasper Sørensen <[email protected]> > > > > > > > > > > > >> Since we don't have JIRA up and running yet, here's a report via > > > email > > > > > of > > > > > >> a bug we just encountered at Human Inference. > > > > > >> > > > > > >> The Salesforce.com web service is giving back an error when you > > > > update a > > > > > >> record (SObject) that does not exist. We do not handle this > error > > in > > > > > >> MetaModel. Since the Salesforce.com module should behave like > any > > > > other > > > > > >> module, it should not throw any exceptions if you try to update > > > > records > > > > > >> that do not exist. To examplify, a SQL statement like this: > > > > > >> > > > > > >> UPDATE [table] SET foo = 'bar' WHERE baz = 1234; > > > > > >> > > > > > >> Would return without problems even though there are no records > > where > > > > baz > > > > > >> = 1234. In the current Salesforce.com module it throws back an > > > > > exception. > > > > > >> > > > > > >> We'll happily provide a patch to fix this asap and hope it can > be > > > > added > > > > > >> to our initial Apache release. > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > >
