Thanks Kasper for pointing to the exact fix. @Arvind, I have committed the fix for first 2 issues. May be you want to review the Disclaimer file content. Also if you share more info on the test failure on MacOS then we can solve that. I also don't have a Mac.
Regards Ankit On Tue, Nov 26, 2013 at 9:46 AM, Kasper Sørensen < [email protected]> wrote: > Build works here if I fix the rat plugin by adding this on line 197 of > /pom.xml: > > <exclude>DEPENDENCIES</exclude> > > Arvind, can you elaborate which tests fail on your Mac OS? Sorry I don't > have a Mac OS myself to test it on, it might be a bug in one of the > unittests. > > Kasper > > > 2013/11/26 Kasper Sørensen <[email protected]> > > > Thank you for pointing these things out Arvind. So I guess we still have > a > > little work to do Ankit :-) Are you up for making these small > > modifications/additions? > > > > > > 2013/11/22 Arvind Prabhakar <[email protected]> > > > >> Ankit, > >> > >> Thanks for your hard work and that of the fellow community members to > get > >> this release candidate out. This is great progress and I believe you are > >> very close to making your first incubating release now. There are a few > >> issues that I noticed that have been mentioned below. Please glance > >> through > >> them and let me know if you have any questions. > >> > >> I verified the following for > MetaModel-4.0.0-incubating-source-release.zip > >> [1] only. > >> > >> The following checked out OK: > >> * Verified signature > >> * Verified checksums (md5, sha1) > >> * Verified tag against source distribution > >> > >> Following issues were found: > >> * RAT test fails in the source artifact since it does not exclude > >> DEPENDENCIES file. > >> * No DISCLAIMER file found. See [2] for details. > >> * Source distribution does not build (test failures on Mac OSX 10.9), > and > >> no build instructions found. > >> > >> Give the above I am -1 for this release candidate. > >> > >> [1] > >> > >> > https://repository.apache.org/content/repositories/orgapachemetamodel-142/org/apache/metamodel/MetaModel/4.0.0-incubating/MetaModel-4.0.0-incubating-source-release.zip > >> [2] > >> > http://incubator.apache.org/guides/releasemanagement.html#notes-disclaimer > >> > >> Regards, > >> Arvind Prabhakar > >> > >> > >> On Wed, Nov 20, 2013 at 4:35 AM, Ankit Kumar <[email protected] > >> >wrote: > >> > >> > Hi All, > >> > > >> > Please vote on releasing the following candidate as Apache Metamodel > >> > (incubating) version 4.0.0. > >> > This will be the first incubator release for MetaModel project in > >> Apache. > >> > > >> > The tag to be voted on is v4.0.0-incubating : > >> > > >> > > >> > https://git-wip-us.apache.org/repos/asf?p=incubator-metamodel.git;a=tag;h=refs/tags/MetaModel-4.0.0-incubating > >> > > >> > > >> > Release artifacts are signed with the following key: > >> > https://people.apache.org/keys/committer/ankitkumar2711.asc > >> > > >> > The staging repository for this release can be found at: > >> > > >> > https://repository.apache.org/content/repositories/orgapachemetamodel-142 > >> > > >> > Please vote on releasing this package as Apache MetaModel > >> 4.0.0-incubating. > >> > The vote is open until < DATE AND TIME FOR THE NEXT 72 hours> and > >> > passes if a majority of at least 3 IPMC votes are cast. > >> > > >> > [ ] +1 Release this package as Apache MetaModel 4.0.0-incubating > >> > [ ] -1 Do not release this package because ... > >> > > >> > > >> > Regards > >> > Ankit > >> > > >> > > > > >
