Hi Alberto, I gave you project a quick look, and it's already quite awesome work! :-) I like the way you discover metadata ... I didn't know of that approach, so I am looking forward to trying it out.
A quick thing I noticed is that your DataContext overrides the executeQuery(Query) method. You probably shouldn't do that, since your superclass does all the hard work. Simply implement the materializeTable(...) method and you're much better off. If you upgrade your dependency to rely on the latest version of MM (4.2) then you will even have a lot more helper methods to implement in your DataContext. Such as executePrimaryKeyLookupQuery and others. Doing that will quickly get your going to a very broad query support and better performance. Best regards, Kasper 2014-09-12 13:27 GMT+02:00 Hans Drexler <[email protected]>: > Just a small correction. MetaModel is not my project. I am not nearly > smart enough for that. But I'll do my best to give you some worthwhile > feedback. > > Cheers, > > Hans > > -----Original Message----- > From: Alberto Rodriguez [mailto:[email protected]] > Sent: Friday, September 12, 2014 1:03 PM > To: [email protected] > Subject: Re: ElasticSearch Module > > Hi Hans, > > no worries!! I think your project is awesome and I would like to > contribute somehow. > > I will keep working on the module. > > Regards, > > Alberto > > 2014-09-12 12:58 GMT+02:00 Hans Drexler <[email protected]>: > > > Hi Alberto, > > > > What great news. I will checkout your code and try to give comments. > > Thank you for your contributon. > > > > Regards, > > > > Hans > > > > Op 12 sep. 2014 11:13 schreef Alberto Rodriguez <[email protected]>: > > Hi there, > > > > as per our previous discussion I have been taking a look at the > > elasticsearch module for metamodel. > > > > I have been working on it and I have a very simple version which is > > already fetching the metadata from ES. I have also managed to make > > simple queries work (queries without filters and where clauses). > > > > Could you please have a look at the project on my github account and > > let me know what you think about it?: Metamodel-elasticsearch module > > <https://github.com/ardlema/metamodel-elasticsearch> > > > > Thank you in advance. > > > > Kind regards, > > > > Alberto > > >
