[
https://issues.apache.org/jira/browse/METAMODEL-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152871#comment-14152871
]
Alberto Rodriguez commented on METAMODEL-80:
--------------------------------------------
Your changes look good to me, I like the way you are using the scroll API,
I should use it from the beginnig, good job!! I have a couple of questions
though:
- Why are you using AtomicBoolean instead of boolean to define the
_closed variable?
- Not fully understand the last part of the next() method. Why are you
trying to scroll to the next set of hits?
Alberto Rodríguez
<http://www.stratio.com/>
Avenida de Europa, 26. Ática 5. 3ª Planta
28224 Pozuelo de Alarcón, Madrid
Tel: +34 91 352 59 42 // *@stratiobd <https://twitter.com/StratioBD>*
> Change the ElasticSearch DataSet cursor implementation
> ------------------------------------------------------
>
> Key: METAMODEL-80
> URL: https://issues.apache.org/jira/browse/METAMODEL-80
> Project: Metamodel
> Issue Type: Improvement
> Reporter: Alberto Rodriguez
> Assignee: Alberto Rodriguez
> Priority: Minor
>
> The ElasticSearch DataSet implementation is currently eagerly loading all the
> results into an array. This is a potential problem for large datasets that
> could cause out of memory exceptions.
> We should get an active cursor instead the current one.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
