[ 
https://issues.apache.org/jira/browse/METAMODEL-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156743#comment-14156743
 ] 

ASF GitHub Bot commented on METAMODEL-18:
-----------------------------------------

Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/incubator-metamodel/pull/2#discussion_r18351406
  
    --- Diff: full/src/main/java/org/apache/metamodel/DataContextFactory.java 
---
    @@ -649,4 +651,16 @@ public static UpdateableDataContext 
createCouchDbDataContext(String hostname, In
         public static QueryPostprocessDataContext 
createElasticSearchDataContext(Client client, String indexName) {
             return new ElasticSearchDataContext(client, indexName);
         }
    +
    +    /**
    +     * Creates a new Cassandra datacontext.
    +     * @param cluster
    +     *       The Cassandra client
    +     * @param keySpaceName
    +     *       The Cassandra key space name
    +     * @return a DataContext object that matches the request
    +     */
    +    public static QueryPostprocessDataContext 
createCassandraDataContext(Cluster cluster, String keySpaceName) {
    --- End diff --
    
    Should return DataContext (the interface) and not 
QueryPostprocessDataContext (an abstract class which we don't want to expose to 
end-users).


> Cassandra DB support for MetaModel
> ----------------------------------
>
>                 Key: METAMODEL-18
>                 URL: https://issues.apache.org/jira/browse/METAMODEL-18
>             Project: Metamodel
>          Issue Type: New Feature
>            Reporter: Kasper Sørensen
>            Priority: Critical
>
> A new module for MetaModel, providing support for Cassandra.
> Note that Cassandra in many respects is similar to HBase, and we might run 
> into some of the same issues. Check METAMODEL-13 for our HBase module JIRA 
> issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to