Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/incubator-metamodel/pull/2#discussion_r18351406
--- Diff: full/src/main/java/org/apache/metamodel/DataContextFactory.java
---
@@ -649,4 +651,16 @@ public static UpdateableDataContext
createCouchDbDataContext(String hostname, In
public static QueryPostprocessDataContext
createElasticSearchDataContext(Client client, String indexName) {
return new ElasticSearchDataContext(client, indexName);
}
+
+ /**
+ * Creates a new Cassandra datacontext.
+ * @param cluster
+ * The Cassandra client
+ * @param keySpaceName
+ * The Cassandra key space name
+ * @return a DataContext object that matches the request
+ */
+ public static QueryPostprocessDataContext
createCassandraDataContext(Cluster cluster, String keySpaceName) {
--- End diff --
Should return DataContext (the interface) and not
QueryPostprocessDataContext (an abstract class which we don't want to expose to
end-users).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
