I think it still makes sense to add these to the platform script. What if the mvn plugin breaks or starts working in an unexpected way? This would help us uncover issues there.
But good point to bring up, Ryan. On Wed, May 3, 2017 at 8:32 AM, Ryan Merriman <[email protected]> wrote: > We are using a mvn plugin that automatically installs the correct version > of node and npm locally, at least for the management UI. > > Are there other parts of the project that depend on these tools? Is it > desirable to include this even if they aren't a prerequisite for building? > I don't think it's a bad idea to include it either way, just want people to > be aware of the plugin. > > > On May 3, 2017, at 7:19 AM, nickwallen <[email protected]> wrote: > > > > Github user nickwallen commented on the issue: > > > > https://github.com/apache/incubator-metron/pull/562 > > > > +1 Thanks, Otto! Tested on OSX and CentOS. Worked as expected. > > > > > > --- > > If your project is set up for it, you can reply to this email and have > your > > reply appear on GitHub as well. If your project does not have this > feature > > enabled and wishes so, or if the feature is enabled but not working, > please > > contact infrastructure at [email protected] or file a JIRA > ticket > > with INFRA. > > --- >
