I agree with Nick about the PR template insofar as we should keep it simple. And for any checklist items, we should seek to automate as much as possible. We've already made some strides with Justin Leet's changes to include site-book building in the main build, for instance. I'd prefer to add this to developer guidelines on the wiki or a general dev README in the project.
On Wed, May 3, 2017 at 7:26 AM, Nick Allen <[email protected]> wrote: > +0 I am not a fan of the PR template. In my opinion, there is too much > text already and I ended up just skipping over it. I think it gets in the > way of a contributor actually describing their change. Just my opinion. I > know many others disagree and find value in it. > > On Wed, May 3, 2017 at 8:27 AM, Otto Fowler <[email protected]> > wrote: > > > For example: we have recently introduced dependencies on Docker, Node.js > > and NPM that needed to be added later. > > > > > > On May 3, 2017 at 08:25:21, Otto Fowler ([email protected]) wrote: > > > > I think we should have documented in the template and guidelines > something > > to the extent ( appropriate for the document ) of : > > > > “Metron provides a platform_info.sh script in metron-deployment/scripts > > that outputs information that may be important to troubleshooting build > and > > deployment issues. It is important if any development introduces new > > technology to the stack that effects the build and deployment by it’s > > presence or version, that the platform_info.sh be updated to reflect that > > information.” > > > > > > pr: > > [ ] platform_info.sh updated for new dependencies > > >
