Github user JonZeolla commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/564#discussion_r115301858
  
    --- Diff: 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/configuration/elastic-site.xml
 ---
    @@ -189,7 +189,12 @@
         </property>
         <property>
             <name>network_host</name>
    -        <value>"_lo:ipv4_","_eth0:ipv4_"</value>
    -        <description>Network interface(s) ES will bind to within each 
node. Confirm names via ifconfig.  Should have entries for primary external and 
loopback interfaces, with :ipv4 annotation and quote marks around each entry: 
"_lo:ipv4_","_eth0:ipv4_"</description>
    +        <value>[ _local_ ]</value>
    +        <description>Network interface(s) ES will bind to within each 
node. Use [ _local_ ] for single-node install; change to [ _local_, _site_ ] 
(including square brackets) for typical cluster install. See 
https://www.elastic.co/guide/en/elasticsearch/reference/2.3/modules-network.html
 for ES documentation.</description>
    +    </property>
    +    <property>
    +        <name>network_publish_host</name>
    --- End diff --
    
    Shouldn't we just change it to be optional, if it's actually optional?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to