Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/586
@simonellistonball Right, I'm not attempting to cover any type of log that
can come in, based on the bro documentation, because bro logs are heavily
extensible and therefore it is hard to detect what all *could* come in from a
given bro install. There are also a lot of fields that exist in the bro
documentation for a specific log type that are not on by default, but can be
turned on. I plan to step towards support of those fields with various PRs,
but not do it all with this first stab unless it's strongly encouraged.
That said, I will do some more work on the unit and integration tests to
get better coverage, as there most definitely may be some missing, optional
fields which I didn't catch in the tests.
@nickwallen Right, that makes sense. In a minute I'll push out my first
pass at the integration tests, and I'll take another look at the tests this
coming week and fill in any of the gaps.
As an aside, I explicitly did not add these new logs to the bro
sensor-stub, but I would consider doing so at some point in the future. Since
there isn't a default dashboard that uses these logs, I didn't think it would
be very useful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
