GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/593
METRON-958: PCAP Query job throws exception when no files returned by time
range query
https://issues.apache.org/jira/browse/METRON-958
When the PCAP topology is run against a Kafka topic with multiple
partitions, there will be at least one file per partition. The current MR job
only expects adding a left trailing file for a single partition, so we miss
files when performing the filter by timestamp on the filenames and it ends up
throwing an exception.
## Testing
### Part 1
To test this, run a pcap topology against a Kafka topic with multiple
partitions, preferably 3 or more. You'll also want to set kafka.pcap.maxTimeMS
to something like 5 minutes (300000). You'll need to install pycapa and run it
to create some data -
https://github.com/apache/metron/tree/master/metron-sensors/pycapa. Let it run
for 4-5 minutes. To keep it simple, stop it shy of 5 minutes so there's only 1
large-ish file per partition.
Run pcap inspector on one of the files and make note of the starting and
ending time. Pick a time in the middle and run a pcap query using that time,
down to the minute, as a filter. e.g.
`${METRON_HOME}/bin/pcap_query.sh query -df "yyyyMMddHHmm" -st 201705162000
--query ""`
### Part 2
Run a pcap query with a time outside of the range of times included in the
pcap data and verify an exception is not thrown.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron METRON-958
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/593.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #593
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
