Github user simonellistonball commented on a diff in the pull request:

    https://github.com/apache/metron/pull/581#discussion_r118686928
  
    --- Diff: metron-interface/metron-config/scripts/package.json ---
    @@ -9,7 +9,8 @@
         "http-proxy-middleware": "0.17.4",
         "optimist": "0.6.1",
         "serve-favicon": "2.4.2",
    --- End diff --
    
    A somewhat better approach to capturing licenses is the npm-license-checker 
modules, which does what your grep does, but also checks in for LICENSE files 
and README files with license text in. 
    
    FYI: the license mentioned in see COPYING.txt is tweetnacl, which is Public 
Domain, so fine.
    
    Apologies for the adhoc analysis, but here is a pivot marked up showing the 
UNKOWNS and things we need to check. 
    
    The weird one seems to be the LGPL license for xmldom; not sure why this is 
getting pulled in, but seems to be in the chain 
angular-cli->ember-cli->testem->xmldom. This seems to be because the old 
version of angular-cli (as opposed to @angular/cli) brings in the entire 
ember-cli library, so could be easily avoided.
    
    As for all the unknowns, I've not had chance to go through and check them 
yet, but thought I'd share this sheet to save others time if they want to go 
hunting.
    
    [license 
analysis.xlsx](https://github.com/apache/metron/files/1031647/license.analysis.xlsx)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to