GitHub user simonellistonball opened a pull request:
https://github.com/apache/metron/pull/617
METRON-996 Performance improvement for ASA parser
Moved the compilation of Grok into initialisation and created a map of Grok
instances for each ASA message type. No functional changes, but a significant
performance improvement according to perfidix benchmarks (see JIRA).
All functional tests related to the parser have been run, performance tests
were run manually with a simple Perfidix harness (not included) running the
parse method against sample messages taken from the existing unit tests.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/simonellistonball/incubator-metron METRON-996
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/617.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #617
----
commit 49c4bc63cca8d31e27b5cdee0d2b8787ebefb9be
Author: Simon Elliston Ball <si...@simonellistonball.com>
Date: 2017-06-11T12:45:18Z
Moved compilation of Grok statements into init, and produced a hashmap of
Grok instances for each ASA tyype for performance gains
commit a095b9ecccaf07442d2bcd767b2a7198ff4dffbc
Author: Simon Elliston Ball <si...@simonellistonball.com>
Date: 2017-06-11T12:49:26Z
Fixed style conventions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
