Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/616
@ottobackwards , thanks very much for tackling this admittedly large review.
> So, the test plan for this is...?
"For a general test plan for all Stellar functionality within Metron,
please see #468 's test plan."
It's long, hence not reproduced here.
> So we have a StatefulExecutor...
The base executor is org.apache.metron.stellar.common.BaseStellarProcessor,
formerly org.apache.metron.common.stellar.BaseStellarProcessor. It parses and
evaluates Stellar expressions, with caching of the parse, and with given
context (variables), variableResolver, and functionResolver. It can return any
Stellar data type. It also provides a validate() method.
The "stateful" executor,
org.apache.metron.stellar.common.StellarStatefulExecutor, assists with
Aggregators, where state needs to persist across multiple invocations of the
same entity, and in fact was formerly located at
org.apache.metron.profiler.stellar.StellarExecutor. It was renamed when I
relocated it, to avoid conflict with the Shell executor,
org.apache.metron.stellar.common.shell.StellarExecutor, which is significantly
different. I deemed the stateful executor to be Stellar functionality rather
than Profiler, and moved it. The Aggregator functions will also be moved into
Stellar, but that will be in Step 3, which will be a different PR.
I agree in future it would be nice to have design documents, for Stellar
and other parts of Metron.
> I think the readme should be \[expanded into a Language Reference Manual
:-) \]
> ...maybe it should be added to the follow on list.
Yah, that would be good. I've opened
[METRON-998](https://issues.apache.org/jira/browse/METRON-998), as a follow-on
task.
> I think that this could be a feature branch.
Since this started as a regular PR, I'd like to finish this one that way.
But I agree, before starting Part 3 I'll petition to create a feature branch
for the next set(s) of work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
