Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/526
@merrimanr Here is the list of consolidated suggestion on this PR. I worked
on the comments that are related to code guidelines and readability of the
code. As for improving coverage, i can submit a separate PR ?.
- First, there are some very minor style issues. Several lines are not
terminated so that should be cleaned up. _-Done_
- I feel like the organization of the "Sensor Config for parser e2e1" is
too broad. I would prefer tests to be broken down a little bit more, by feature
or editor pane if possible. _-Done_
- Is the raw JSON editor tested? _-Will cover in a separate PR_
- Advanced config? _-The advanced config is asserted in edit flow. We can
a case to test in add flow too_
- Are we testing how we format field names and values in the read-only and
list view? _-This is indirectly tested when we try to get the field value by
css class names_
- When we're editing sensors are we verifying the correct config is saved?
_-Yes_
- Are we verifying the editor looks correct when we open an existing sensor
(not just the primary form but child panes as well)? _-This is indirectly
tested when we try to get the field value by css class names_
- Are we testing the general settings page? _-Will cover in separate PR_
- setup script to create the test cases so that they will not be affected
by new parsers being added? _-Will cover in seperate PR_
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
