Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/624#discussion_r124922214
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java
---
@@ -148,6 +150,15 @@ public void stop() {
@Before
public void setup() throws Exception {
+ runner = new ComponentRunner.Builder()
+ .withComponent("kafka", kafkaWithZKComponent)
+ .withCustomShutdownOrder(new String[]{"kafka"})
+ .build();
+ try {
+ runner.start();
+ } catch (UnableToStartException e) {
+ e.printStackTrace();
--- End diff --
Why not just kill the try/catch entirely? If it fails, it might as well
blow up the tests anyways
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
