Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/624#discussion_r125007939 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java --- @@ -61,6 +62,7 @@ private static final int KAFKA_RETRY = 10; @Autowired private KafkaComponent kafkaWithZKComponent; + private ComponentRunner runner; --- End diff -- no, I think we've done enough. We, honestly, need a test guidance document similar to the parser testing document that I created as part of this ticket. It's become evident from this exercise that we can provide some over-arching guidance here to limit the probability of us arriving in this situation again. But that's a follow-on, IMO.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---