Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/622#discussion_r127329675
--- Diff:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/SaltyRowKeyBuilder.java
---
@@ -44,7 +46,17 @@
* <li>group(s) - The group(s) used to sort the data in HBase. For
example, a group may distinguish between weekends and weekdays.
* <li>period - The period in which the measurement was taken. The first
period starts at the epoch and increases monotonically.
* </ul>
+ *
+ * This row key builder has no logic to decode a row key, nor is the row
key generated by this builder
+ * easily decodable. More specifically, the profile, entity, groups and
period that make up the row key
+ * cannot be extracted from a previously generated row key. This makes it
difficult to answer questions
+ * like; What entities are included in this profile? What is the period
for this profile? Use the
+ * DecodableRowKeyBuilder instead.
+ *
+ * @deprecated Replaced by DecodableRowKeyBuilder
+ * @see DecodableRowKeyBuilder
*/
+@Deprecated
public class SaltyRowKeyBuilder implements RowKeyBuilder {
--- End diff --
I marked the old `RowKeyBuilder` as deprecated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
