Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/654#discussion_r127526102
--- Diff:
metron-platform/metron-writer/src/test/java/org/apache/metron/writer/BulkWriterComponentTest.java
---
@@ -118,6 +118,20 @@ public void writeShouldProperlyAckTuplesInBatch()
throws Exception {
}
@Test
+ public void writeShouldProperlyAckTuplesWhenWriterDisabled() throws
Exception {
--- End diff --
It's not a huge deal, but is it possible to write a test where one writer
is enabled and one is disabled? I'm mostly concerned about making sure
everything is spelled out, to avoid any regressions if anything in here gets
refactored.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
