Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/620
@iraghumitra I really like what you've done. There is a ton of
functionality here and it works great. I did not find any functional problems
beyond what you've already called out. I think we should get this into master
and start iterating.
Also, thank you so much for summarizing the discussions that have already
occurred in the PR description. That was a HUGE help to me in reviewing.
I need to hold off on the +1 until we address a couple items.
* [ ]
[Licensing](https://github.com/apache/metron/pull/620#issuecomment-317834046)
* [ ]
[Tests](https://github.com/apache/metron/pull/620#issuecomment-317788710)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
